Winch: Float conversion instructions#7773
Merged
saulecabrera merged 2 commits intoJan 12, 2024
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Not sure why https://github.com/bytecodealliance/wasmtime/actions/runs/7504830983/job/20432782059 failed. Running |
Member
|
It's because the conversion spec tests assert for traps https://github.com/bytecodealliance/wasmtime/pull/7773/files#diff-823efed0acf795e9245a551aadae26695321f840cbe4b51b12410b26bde35c45R70 and currently since Winch doesn't fully encode unwind information, any tests that trap will fail on Windows. You need to add the conversion suites that trap here https://github.com/bytecodealliance/wasmtime/blob/main/build.rs#L210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6528. Adds support for the following instructions to Winch:
i32.trunc_f32_si32.trunc_f32_ui32.trunc_f64_si32.trunc_f64_ui64.trunc_f32_si64.trunc_f32_ui64.trunc_f64_si64.trunc_f64_ui32.reinterpret_f32i64.reinterpret_f64f32.convert_i32_sf32.convert_i32_uf32.convert_i64_sf32.convert_i64_uf64.convert_i32_sf64.convert_i32_uf64.convert_i64_sf64.convert_i64_uf32.reinterpret_i32f64.reinterpret_i64f32.demote_f64f64.promote_f32